BLD: Use conda(-forge) compilers #38084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think a whatsnew is needed. But maybe we should update the contributing docs related to installing a compiler? https://pandas.pydata.org/docs/dev/development/contributing.html#installing-a-c-compiler (at mention that that manual step is not needed when installing the env using conda) Does this also work on Windows? (I thought there you still need to manually install MS build tools in addition?) |
You still need the build tools but I have mentioned the exact command to get the minimally necessary VS2017 components for that. This should also be sufficient for solely- |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the compiler setup from conda-forge inside a conda environment. The compilers in conda-forge can be different and slightly incompatible with the system ones causing some headaches. Also this hopefully helps with initial setup of new contributors.
Is this worth a whatsnew entry?
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff